Making HRD work in signup page and showing an error when HRD is detected in the forgot password page #1278
Conversation
…ded in the forgot password page
There was a problem hiding this comment.
If the error copy wasn't reviewed by design it should. It's the first 3 lines error message I see and I personally don't like it (visually).
What I also find confusing of the PR is that there are many i18n values updates but the key changes on some of them are not changes on others, what's the reason behind this? i.e. hr.js adds a lots of new keys while fi.js doesn't.
|
@lbalmaceda - I wrote that and agree that it doesn't look great as all-caps. We could remove that first sentence, TBH, and I think the message would be understandable. It's really just there to provide a path forward for folks. I don't think the end user is going to care about Enterprise or not. |
|
as for the translation: they probably weren't translated before. |
|
I don't think it this is a big deal, but it is a design issue in lock. Error messages were intended for shorter all caps errors. I think we can live with it for the moment, I don't want to introduce design changes for this specific issue. |
lbalmaceda
changed the title
| @@ -36,6 +40,21 @@ export default class ResetPassword extends Screen { | |||
| getScreenTitle(m) { | |||
| return i18n.str(m, 'forgotPasswordTitle'); | |||
| } | |||
| isSubmitDisabled(m) { | |||
There was a problem hiding this comment.
Where is this used? Tests?
fix #1250