In SSO mode, hide the password input instead of removing it from the DOM #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
approved these changes
Jun 20, 2018
| @@ -70,7 +66,12 @@ export default class LoginPane extends React.Component { | |||
| <div> | |||
| {header} | |||
| {fieldPane} | |||
| {passwordPane} | |||
| <PasswordPane | |||
There was a problem hiding this comment.
Why are you switching from using a const? Not a blocker, just curious
There was a problem hiding this comment.
the const was a conditional. It was adding/removing the input from the DOM based on that condition. This triggered the bug itself. So, now, it will always have the input, it will only use css to hide the input
| @@ -179,6 +179,9 @@ export const hasOneSocialBigButton = hasOneViewFn( | |||
| '.auth0-lock-social-button.auth0-lock-social-big-button' | |||
| ); | |||
| export const hasPasswordInput = hasInputFn('password'); | |||
There was a problem hiding this comment.
How is this used? Should it account for the input being hidden?
There was a problem hiding this comment.
Maybe that's handled by the hasHiddenPasswordInput you added but still worth a consideration.
There was a problem hiding this comment.
not sure what you mean 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1397
The issue happened because Lock was REMOVING the password input from the DOM. The fix was to let the input in the DOM, but add a css class that hides the input.
Before:
After:
