Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use span for icon buttons #1478

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Use span for icon buttons #1478

merged 1 commit into from
Sep 10, 2018

Commits on Sep 8, 2018

  1. Use span for icon buttons 

    Fixes regression in v11.9.0

In 11.9.0, for accessibility, some 'span' tags were switched to 'button'.
However hitting the enter key triggers the onClick on buttons. (not sure where this is in the code, but it might be worth changing)
So switching back to 'span' for now.
    @andrew-me
    andrew-me committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    2cf0f0e View commit details
    Browse the repository at this point in the history