Update telemetry format and rules #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
reviewed
Mar 27, 2019
| version: __VERSION__, | ||
| lib_version: auth0.version | ||
| }; | ||
| const { auth0Client } = qs.parse(window.location.search.substr(1)); |
There was a problem hiding this comment.
won't this include anything on the query, not just the auth0Client query param?
There was a problem hiding this comment.
this is parsing the query string and getting only the auth0Client key
There was a problem hiding this comment.
Ah, I just see the destructuring 👍
|
@luisrudge - So ... before we merge this in, I think we should resolve the "telemetry on the ULP" question. As in ... should we just nuke telemetry when Lock/Auth0.js is used on our server? I tend to lean towards "yes" here. I'll post this internally for discussion 👍 |
joshcanhelp
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added new telemetry format
Testing