Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added login_required to unhandled authorization errors #1629

Merged
merged 2 commits into from
Apr 11, 2019

Conversation

benhamiltonpro
Copy link
Contributor

Changes

We found an issue with the "last time you logged in with" screen where the silent auth fails because the inactivity timeout/required login after time limit was reached. As if someone went on vacation, came back, and tried to sso back in. The 'login_required' error gets fired because the user needs to re-authenticate but was not emitted as an authorization error. Without this change, there is no way to handle this scenario as it fails to fire lock.on('authorization_error') event.

References

Support Ticket #00426103

Testing

Repro steps:

  1. Have a lock with rememberLastLogin set to true
  2. Go to Tenant > Advanced > Log In Sesion Management
  3. Set the inactivity timeout to 1 minute
  4. Login normally with the lock
  5. Wait a minute (note: your lock will need to be triggered with .show() to display the "last time you logged in with" screen)
  6. Remember last login will fire and when you click on it, the error text "WE'RE SORRY, SOMETHING WENT WRONG WHEN ATTEMPTING TO LOG IN." will appear and no authorization_error is fired.
  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

benhamiltonpro and others added 2 commits April 9, 2019 14:01
We found an issue with the "last time you logged in with" screen where the silent auth fails because the inactivity timeout/required login after time limit was reached. As if someone went on vacation, came back, and tried to sso back in. The 'login_required' error gets fired because the user needs to re-authenticate but was not emitted as an authorization error. Without this change, there is no way to handle this scenario as it fails to fire lock.on('authorization_error') event.
@luisrudge luisrudge merged commit 93e5291 into auth0:master Apr 11, 2019
@luisrudge luisrudge added this to the v11.14.2 milestone Apr 11, 2019
@luisrudge luisrudge changed the title Added unhandled authorization error Added login_required to unhandled authorization errors Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants