Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent form submit when password is empty #1654

Merged
merged 2 commits into from
May 23, 2019
Merged

Prevent form submit when password is empty #1654

merged 2 commits into from
May 23, 2019

Conversation

luisrudge
Copy link
Contributor

fix #1282

Changes

Always set the password to invalid when there's no password

@luisrudge luisrudge requested a review from a team May 22, 2019 23:04
@luisrudge luisrudge merged commit b21499d into master May 23, 2019
@luisrudge luisrudge deleted the fix/empty-password-submit branch May 23, 2019 02:42
@luisrudge luisrudge added this to the v11.16.1 milestone Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpatrick davidpatrick davidpatrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v11.16.1
Development

Successfully merging this pull request may close these issues.

Empty fields not properly handle with Lock
2 participants
@luisrudge @davidpatrick