Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Signup Success Event #1754

Merged
merged 3 commits into from
Nov 28, 2019
Merged

New Feature: Signup Success Event #1754

merged 3 commits into from
Nov 28, 2019

Conversation

fostergn
Copy link
Contributor

@fostergn fostergn commented Nov 23, 2019

Changes

Please describe both what is changing and why this is important. Include:

  • adding "signup success" event

References

Please include relevant links supporting this change such as a:

n/a

Please note any links that are not publicly accessible.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@fostergn fostergn requested a review from a team November 23, 2019 22:37
@fostergn
Copy link
Contributor Author

I'm new to contributing to this project and was looking for an existing test to base my own tests on. I didn't see an existing test for an event like signup_failed thought

@stevehobbsdev stevehobbsdev added this to the vNext milestone Nov 28, 2019
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @fostergn!

@stevehobbsdev stevehobbsdev merged commit 2348539 into auth0:master Nov 28, 2019
@fostergn fostergn deleted the signup-success-event branch November 29, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants