Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default token validation leeway to 60 sec #1770

Merged
merged 2 commits into from
Dec 20, 2019
Merged

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Dec 17, 2019

Changes

This PR bumps Auth0.js to 9.12.1 to take advantage of a new default leeway. It also changes the default leeway specified by Lock to align with Auth0.js to 60 seconds.

References

Aligns with this change: auth0/auth0.js#1062

Testing

Unit test coverage added. It's not immediately obvious from the way the diff has worked out, but the change is verified in the form of an additional snapshot. Existing tests used a leeway of 60 seconds; these were changed to 30 seconds to distinguish these tests from the new test that sends the default of 60.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@stevehobbsdev stevehobbsdev added this to the v11.20.1 milestone Dec 20, 2019
@stevehobbsdev stevehobbsdev merged commit 78be817 into master Dec 20, 2019
@stevehobbsdev stevehobbsdev deleted the deps/auth0-js branch December 20, 2019 15:07
jfromaniello pushed a commit to jfromaniello/auth0-lock that referenced this pull request Mar 5, 2020
* Bumped auth0-js to 9.12.1

* Update default leeway to 60 sec
jfromaniello pushed a commit to jfromaniello/auth0-lock that referenced this pull request Jul 23, 2020
* Bumped auth0-js to 9.12.1

* Update default leeway to 60 sec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants