Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add translate 'social_signup_needs_terms_acception' for japanese #1835

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

mag-chang
Copy link
Contributor

Changes

When I set the 'mustAcceptTerms' option was True, I noticed that the message when I signed up without agreeing to the terms of service was not translated.

  • I was add translate string to 'social_signup_needs_terms_acception' key.

References

Please include relevant links supporting this change such as a:

  • support ticket
  • community post
  • StackOverflow post
  • support forum thread

Please note any links that are not publicly accessible.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@mag-chang mag-chang requested a review from a team March 26, 2020 11:07
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@stevehobbsdev stevehobbsdev added this to the vNext milestone Mar 26, 2020
@stevehobbsdev stevehobbsdev merged commit c8418a2 into auth0:master Mar 26, 2020
@mag-chang mag-chang deleted the i18n-add-for-japanese branch March 27, 2020 00:36
davidpatrick pushed a commit to davidpatrick/lock that referenced this pull request Jun 12, 2020
jfromaniello pushed a commit to jfromaniello/auth0-lock that referenced this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants