Fix send sms error event #1856
Merged
Fix send sms error event #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sendSms has an error there should be an event fired so clients can listen to and react upon it.
Test emit authorization_error on sendSms error
|
Thanks @blankg! |
stevehobbsdev
approved these changes
May 7, 2020
davidpatrick
pushed a commit
to davidpatrick/lock
that referenced
this pull request
Jun 12, 2020
* Fix sendSmsError to emit AuthorizationErrorEvent When sendSms has an error there should be an event fired so clients can listen to and react upon it. * Update passwordless actions test Test emit authorization_error on sendSms error * fix snapshot test Co-authored-by: Steve Hobbs <steve.hobbs@auth0.com>
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Jul 23, 2020
* Fix sendSmsError to emit AuthorizationErrorEvent When sendSms has an error there should be an event fired so clients can listen to and react upon it. * Update passwordless actions test Test emit authorization_error on sendSms error * fix snapshot test Co-authored-by: Steve Hobbs <steve.hobbs@auth0.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In the. passwordless sms authentication when there is an error in the sendSms method there is currently no event emitted which the client can listen on and react upon (for example - In our case we would like to report this to our analytics and get a better understanding of users drop in our login funnel).
The fix is in the connection/passwordless/actions.js class to emit AuthorizationErrorEvent.
Testing
Passwordless.actions test is updated to check that AuthorizationError event is emitted.
Checklist