[SDK-1284] Fix for "growing" tabs when repeatedly clicked #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
force-pushed
the
fix/growing-tabs
branch
from
41ab74b
to
0e236b5
Compare
adamjmcgrath
approved these changes
Jul 23, 2020
Merged
This was referenced Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes the growing tabs problem when repeatedly clicking between login
and signup tabs, by removing the
display: initialstyling on the form (thiselement should not be made inline).
Additionally,
display: initialwas added to fix another problem where theform would not show on certain devices when opening Lock. Removing the animation on that element appears to fix that original problem. (See #1745 and #1588).
References
Fixes #1869
Checklist