Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESD-10361] Fix password strength popup overflow issue #1949

Merged
merged 9 commits into from
Dec 16, 2020

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Dec 15, 2020

Changes

This PR provides a host of CSS fixes that fix a number of issues, mainly the password strength popup issue:

  • The password strength popover not being able to properly overflow the primary
    container. In order to fix this, a host of CSS changes were made, which also fixed the other issues below.
  • Removes the need for the dynamically-calculate header
  • Fixes the content popping out of the bottom of the container on small screen
    heights
  • Removes the need for overflow-x: auto which caused rendering issues

I've also adding some instructions about testing a local Lock build through the ULP.

Screenshots highlight the issue with the password strength popover. Might be hard to see given the background, but the top of the popover is clipped against the top of the Lock widget in the before screenshot.

Before

image

After

image

Testing

This was manually tested in all the browsers I can think of, in mobile and desktop view:

  • Firefox 83 on Windows

  • Edge 87 on Windows

  • IE 11 on Windows 10

  • Chrome on Samsung Galaxy S10

  • Chrome on Google Pixel 3

  • Safari on iPhone 11 (iOS 14, simulator)

  • Safari on iPhone 8 (iOS 12, simulator)

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language

Checklist

Gruntfile.js Outdated Show resolved Hide resolved
support/index.html Outdated Show resolved Hide resolved
support/index.html Outdated Show resolved Hide resolved
src/__tests__/ui/box/chrome.test.jsx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants