Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option to hide username in signup view #1954

Merged
merged 4 commits into from
Jan 5, 2021
Merged

An option to hide username in signup view #1954

merged 4 commits into from
Jan 5, 2021

Conversation

saltukalakus
Copy link
Contributor

@saltukalakus saltukalakus commented Dec 29, 2020

Added an option named signUpHideUsernameField to hide username in signup view for the connections that have user name enabled.

Changes

This is the second time I came across this request. Customers have custom DBs and some of the users use the username to log in. Going forward the customers want to enable signup only with an email so they want to hide the username option from the signup view. Customers can't simply disable the user name option from the connections setting due to the legacy users using a username.

The solution hides the signup field with a feature option which is by default turned off. Once the option is enabled it helps to hide the username from Signup.

The solution is coded such that once the feature is enabled a random username is created with the allowed max length and passed to signup API. That is needed because, for the connections that have the username option turned on, passing the username is obligatory.

Screen Shot 2020-12-29 at 20 16 46

I will open a request to the doc team when the PR is merged.

References

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@saltukalakus saltukalakus requested a review from a team as a code owner December 29, 2020 17:33
@saltukalakus saltukalakus marked this pull request as draft December 29, 2020 17:40
@saltukalakus saltukalakus marked this pull request as ready for review December 29, 2020 17:57
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @saltukalakus, thanks.

Just one thing to add; can you add this option into the readme (probably under "database options") that lists the parameter with an appropriate description?

Thanks

@saltukalakus
Copy link
Contributor Author

👋 @stevehobbsdev thank you. I have just updated the README file.

@stevehobbsdev stevehobbsdev self-requested a review January 5, 2021 14:06
@stevehobbsdev stevehobbsdev added this to the vNext milestone Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants