Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove line breaks from passwordless vcode entry instructions #1974

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

stevehobbsdev
Copy link
Contributor

Changes

This PR updates several translation files to remove the line breaks for the code entry instructions. This particular string does not support HTML as it introduces a vulnerability where an attacker could inject malicious code to be executed when the string is shown. Thus, the line breaks are encoded and written to the screen.

References

Fixes #1973

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@stevehobbsdev stevehobbsdev requested a review from a team as a code owner March 12, 2021 10:35
@stevehobbsdev stevehobbsdev added CH: Fixed language file Additions or changes to i18n language files review:small Small review labels Mar 12, 2021
@stevehobbsdev stevehobbsdev merged commit 2964895 into master Mar 15, 2021
@stevehobbsdev stevehobbsdev added this to the vNext milestone Mar 15, 2021
@stevehobbsdev stevehobbsdev deleted the fix-pwd-translations branch March 15, 2021 12:15
@stevehobbsdev stevehobbsdev mentioned this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language file Additions or changes to i18n language files review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spanish translation not rendering HTML in messages correctly
2 participants