Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recaptcha enterprise on lockjs #1986

Merged

Conversation

akmjenkins
Copy link
Contributor

@akmjenkins akmjenkins commented Apr 15, 2021

Changes

  • Support enterprise recaptcha on lockjs.

References

Corresponding PR on universal login prompts

Testing

No flow changes - allows a captcha provider of recaptcha_enterprise to render a recaptcha widget

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@akmjenkins akmjenkins requested a review from a team as a code owner April 15, 2021 01:54
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just thing a couple of the symbols need tightening up.

src/field/captcha/recaptcha.jsx Outdated Show resolved Hide resolved
src/field/captcha/recaptcha.jsx Outdated Show resolved Hide resolved
src/field/captcha/recaptcha.jsx Outdated Show resolved Hide resolved
@stevehobbsdev stevehobbsdev self-requested a review April 19, 2021 10:54
@stevehobbsdev stevehobbsdev added this to the vNext milestone Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:medium Medium review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants