Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More complete support for custom passwordless connections #2105

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

peter-isgfunds
Copy link
Contributor

@peter-isgfunds peter-isgfunds commented Mar 5, 2022

Changes

In a previous PR #1981 a new parameter useCustomPasswordlessConnection was introduced for the Lock configuration. The reason for that change was that it is possible to create passwordless connections outside of the default sms and email. That PR mentions that it can be done via Management API, and it would seem that this includes Terraform (https://github.com/auth0/terraform-provider-auth0) where it seems to be the only way to use passwordless connections.

This PR "completes" the above-mentioned PR where the connection parameter in connection/passwordless/actions.js -> logIn was still hard-coded to either sms or email

References

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

peter-isgfunds and others added 2 commits March 5, 2022 15:43
Update passwordless actions so that `login` can use custom passwordless connection
@peter-isgfunds peter-isgfunds changed the title Better support custom passwordless connections More complete support for custom passwordless connections Mar 5, 2022
@peter-isgfunds peter-isgfunds marked this pull request as ready for review March 5, 2022 22:13
@peter-isgfunds peter-isgfunds requested a review from a team as a code owner March 5, 2022 22:13
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@stevehobbsdev stevehobbsdev merged commit e7da750 into auth0:master Mar 18, 2022
@stevehobbsdev stevehobbsdev added this to the vNext milestone Mar 18, 2022
@stevehobbsdev stevehobbsdev mentioned this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants