[ESD-22866] Disable spellcheck and autocorrect on all sensitive input fields #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were already disabled for the username field spellcheck has recently been discovered to potentially disclose information to browser vendors that provide this feature. So disabling it helps to prevent this. autocorrect is a safari only feature that will autocorrect what it believes to be misspelled words, so this is disabled for user experience
ewanharris
force-pushed
the
ESD-22866
branch
from
ec5f044
to
c244da0
Compare
@ewanharris Let's just do it on those additional fields as well 👍🏻 |
|
@stevehobbsdev, added the properties to those fields |
stevehobbsdev
approved these changes
Sep 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Disables
autocorrectandspellcheckfor all sensitive inputs.spellcheckhas recently been discovered to potentially disclose information to browser vendors that provide this feature. So disabling it helps to prevent this.autocorrectis a safari only feature that will autocorrect what it believes to be misspelled words, so this is disabled for user experience.Both of these were already set for UsernameInput, so this is just bring other fields in line with that. Albeit
spellcheckwas not correctly set.❓ I'm not sure if it would make sense to also enable this for
VcodeInputandPhoneNumberInputtoo ❓Testing
Open the playground in the browser, make typos in the email field and it should no longer give you a red squiggle
Checklist