Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3657] Render sign up confirmation before sign in #2180

Merged
merged 1 commit into from
Oct 4, 2022
Merged

[SDK-3657] Render sign up confirmation before sign in #2180

merged 1 commit into from
Oct 4, 2022

Conversation

ewanharris
Copy link
Contributor

Changes

When a user signs up, if they are logged in as part of the sign up process then the success.logIn message is shown rather than the success.signUp message as the renderSignedInConfirmation function is called first. So call renderSignedUpConfirmation first to ensure the correct message is shown

References

#2159

Checklist

@ewanharris ewanharris requested a review from a team as a code owner October 4, 2022 14:29
@ewanharris ewanharris changed the title Render sign up confirmation before sign in [SDK-3657] Render sign up confirmation before sign in Oct 4, 2022
@ewanharris ewanharris merged commit b5a7a3d into master Oct 4, 2022
@ewanharris ewanharris deleted the SDK-3657 branch October 4, 2022 15:02
@stevehobbsdev stevehobbsdev mentioned this pull request Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewanharris @stevehobbsdev