[IAMRISK-2603] Add support for Arkose #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
requested changes
Oct 2, 2023
There was a problem hiding this comment.
Added a couple of first comments in a first review (but needs another round once tests are green and new tests are added), but this fails existing tests and missed additional tests for the added functionality (you can look at #2387 for previous integrations).
I also see this changes the existing code quite a bit (which is why the tests fail), is that something we can avoid?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2455 +/- ##
==========================================
+ Coverage 41.71% 41.74% +0.03%
==========================================
Files 120 120
Lines 3028 3066 +38
Branches 327 332 +5
==========================================
+ Hits 1263 1280 +17
- Misses 1673 1694 +21
Partials 92 92
☔ View full report in Codecov by Sentry. |
frederikprijck
approved these changes
Oct 6, 2023
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
**Added** - [IAMRISK-2603] Add support for Arkose [\#2455](#2455) ([srijonsaha](https://github.com/srijonsaha)) [IAMRISK-2603]: https://auth0team.atlassian.net/browse/IAMRISK-2603?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding support for Arkose catpcha.
References
https://auth0team.atlassian.net/browse/IAMRISK-2603
Testing
arkose.mp4
Checklist