Only require non-empty value for username when DB connection is custom or import is enabled #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glena
commented
Oct 17, 2016
| @@ -8,7 +8,8 @@ const DEFAULT_CONNECTION_VALIDATION = { username: { min: 1, max: 15 } }; | |||
| const regExp = /^[a-zA-Z0-9_]+$/; | |||
|
|
|||
| function validateUsername(str, validateFormat, settings = DEFAULT_CONNECTION_VALIDATION.username) { | |||
| if (!validateFormat) { | |||
|
|
|||
| if (!validateFormat || !settings) { | |||
There was a problem hiding this comment.
If the connection does not have validation settings, it should only check if the field is empty.
validateFormat overrides this logic to disable validation on login (login should never validate format)
glena
commented
Oct 17, 2016
| @@ -38,7 +38,7 @@ export default class UsernamePane extends React.Component { | |||
| const invalidHint = (str) => { | |||
| const hintKey = invalidHintKey(str); | |||
|
|
|||
| if ("usernameFormatErrorHint" === hintKey && validateFormat) { | |||
| if ("usernameFormatErrorHint" === hintKey && validateFormat && usernameValidation) { | |||
There was a problem hiding this comment.
only show format info in the error, if there is any format restriction.
username validation on signup + removed validation from login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.