Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to override language, dict, logo and primary color on show method #680

Merged
merged 2 commits into from
Oct 31, 2016
Merged

allow to override language, dict, logo and primary color on show method #680

merged 2 commits into from
Oct 31, 2016

Conversation

glena
Copy link
Contributor

@glena glena commented Oct 26, 2016

No description provided.

@hzalaz hzalaz modified the milestone: v10.6.0 Oct 28, 2016
@vasyabigi
Copy link

@glena is it possible to override container too? In SPAs it would be convenient to use Lock as a modal or inline depending on the route. Is it possible to do today? If not, let's add this possibility to show method too.

@glena
Copy link
Contributor Author

glena commented Oct 31, 2016

@vasyabigi No, it is not posible. You will need to re-initialize lock to change this property.

@hzalaz hzalaz merged commit 3e56744 into master Oct 31, 2016
@hzalaz hzalaz deleted the show-options branch October 31, 2016 14:18
@gene1wood gene1wood mentioned this pull request Aug 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzalaz hzalaz hzalaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v10.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@glena @vasyabigi @hzalaz