Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit authorization_error when username/password fails (invalid_user_password) #999

Merged
merged 1 commit into from
Jun 9, 2017
Merged

Emit authorization_error when username/password fails (invalid_user_password) #999

merged 1 commit into from
Jun 9, 2017

Conversation

luisrudge
Copy link
Contributor

fix #998

@luisrudge luisrudge added this to the v10-Next milestone May 10, 2017
hzalaz
hzalaz previously approved these changes Jun 8, 2017
View reviewed changes
Copy link
Member

@hzalaz hzalaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to have a test for this but...

@luisrudge luisrudge force-pushed the feature/emit-auth-error-event-on-invalid-user-or-password branch from 87fc6c3 to 6bb0f42 Compare June 9, 2017 20:08
@luisrudge luisrudge merged commit 5931ffc into master Jun 9, 2017
@luisrudge luisrudge deleted the feature/emit-auth-error-event-on-invalid-user-or-password branch June 9, 2017 20:21
@gene1wood gene1wood mentioned this pull request Aug 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzalaz hzalaz hzalaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v10.17.0
Development

Successfully merging this pull request may close these issues.

Not all errors trigger an event
2 participants
@luisrudge @hzalaz