Add ability to configure proxy with env vars #188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
This PR adds a missing part of the workaround for the axios issue with corporate proxies.
request
andaxios
as well provide the possibility to define proxy config via the environment variables HTTP_PROXY, HTTPS_PROXY and NO_PROXY. Currently the request wrapper doesn't interpret these env vars and doesn't create the neededhttps-proxy-agent
. As a result the axios internal proxy logic is applied which causes the problems with many corporate proxies.This PR adds this missing functionality.
References
#144
axios/axios#2072
Testing
Checklist
master