Update Hapi.js demo server.js #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current Hapi.js demo is written for Hapi.js 13.5 and is no longer fit for purpose for the newer versions of Hapi (post version 17) This version implements the same example, but using Hapi 20.2
adamjmcgrath
approved these changes
Oct 19, 2021
|
Thanks @dankell! |
No problem. I've submitted a PR for the package.json as well. The readme needs to updated as well to reflect the changes to the code. I can give that a try but it's a bit more detailed than I perhaps understand.,, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
The current Hapi.js demo is written for Hapi.js 13.5 and is no longer fit for purpose for the newer versions of Hapi (post version 17)
This version implements the same example, but using Hapi 20.2
References
The Hapi-jwt2 project has updated code for Hapi 17+ https://github.com/dwyl/hapi-auth-jwt2
Hapi v20 took over the Community Branch and is the current BSD licenced branch https://hapi.dev/resources/status#hapi
Testing
This version should work in the same way as the previous example.
Checklist
master