Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Catch errors from JSON.parse #107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Catch errors from JSON.parse #107

wants to merge 2 commits into from

Commits on Feb 6, 2023

  1. Fix: Catch errors from JSON.parse 

    Keep the contract that the decode returns null on errors
    @glensc
    glensc committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    d3eaa90 View commit details
    Browse the repository at this point in the history

  2. Cleanup: Remove unsupported opts.encoding to JSON.parse 

    > reviver Optional
>
> If a function, this prescribes how each value originally produced by
> parsing is transformed before being returned. Non-callable values are
> ignored. The function is called with the following arguments:

- https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/parse
    @glensc
    glensc committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    917319f View commit details
    Browse the repository at this point in the history