Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Remove unsupported opts.encoding to JSON.parse #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glensc
Copy link

@glensc glensc commented Feb 6, 2023

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Remove unsupported opts.encoding to JSON.parse:

reviver Optional

If a function, this prescribes how each value originally produced by
parsing is transformed before being returned. Non-callable values are
ignored.

References

Checklist

  • This change adds test coverage for new/changed/fixed functionality
  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

> reviver Optional
>
> If a function, this prescribes how each value originally produced by
> parsing is transformed before being returned. Non-callable values are
> ignored. The function is called with the following arguments:

- https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/parse
@glensc
Copy link
Author

glensc commented Mar 15, 2024

Can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants