Added iOS SF/ASWeb AuthenticationSession support #187

cocojoe · 2018-11-07T13:17:42Z

Adds support for iOS 11 SFAuthenticationSession & iOS 12 ASWebAuthenticationSession
This enables SSO in iOS 11+

No changes are required by the developer, all is handled internally.

cocojoe · 2018-11-07T13:26:01Z

Replaces #158

joshcanhelp · 2018-11-13T17:40:38Z

webauth/agent.js

        Linking.removeEventListener('url', urlHandler);
-        if (err) {
-          reject(err);
+        if (result && result.url) {


This seems odd ... if there is a result, it could be a success or an error? Is there maybe an error_code property on there when it's an error? Just seems like a non-standard way to pass a result/response to a callback.

So I thought about this at the time, I could change the result to have a status e.g. success or error. Then you're changing the response to the end user as some errors have just been passed straight out from the Native Platform iOS/Android into err. Although looking at certainly iOS errors I don't think the JS side is equipped to process them anyway.

Perhaps we should more strongly define the errors from the native platforms or we need to change the callback method.
Currently using RCTResponseSenderBlock which only accept 1 argument which is an array.
https://facebook.github.io/react-native/docs/native-modules-ios

It might be better to use RCTPromiseResolveBlock although this becomes more of a refactor in both JS/iOS/Android to achieve this.

joshcanhelp · 2018-11-13T17:41:35Z

webauth/index.js

@@ -54,7 +54,7 @@ export default class WebAuth {
      }/${bundleIdentifier}/callback`;
      const expectedState = options.state || state;
      let query = {
-        ...defaults


Was this even working before? Seems like a syntax error:

https://github.com/auth0/react-native-auth0/blob/master/webauth/index.js#L57

No, was in a previous previous 3d party PR. This is a fix for that.

taboulot · 2018-12-04T10:58:16Z

@cocojoe
Any update on when your PR will be merged 😃

cocojoe · 2018-12-04T11:01:13Z

I need to make some changes as I'm not happy with the implementation, even though it works 😄
I should hopefully have some time later this week to pick this up again, thanks.

MSSPL-PiyaleeMaiti · 2018-12-11T10:07:53Z

I am facing the same issue when I can get this updated version.

cocojoe · 2018-12-11T10:34:25Z

I did pick this back up and got delayed, I am on it this week.

iOS 11 SFAuthenticationSession iOS 12 ASWebAuthenticationSession

cocojoe · 2018-12-12T16:46:06Z

@taboulot @MSSPL-PiyaleeMaiti If you are up for trying out this branch and feeding back I would appreciate it.

taboulot · 2018-12-13T13:19:53Z

@cocojoe We will probably test it next will 👍Thanks !

MSSPL-PiyaleeMaiti · 2018-12-13T13:25:33Z

@cocojoe thanks, I will catch you soon.

joshcanhelp

Very minor

joshcanhelp · 2018-12-14T23:24:48Z

ios/A0Auth0.m

@@ -10,8 +13,12 @@
 #import <React/RCTUtils.h>
 #endif

+#define ERROR_CANCELLED @{@"error": @"a0.session.user_cancelled",@"error_description": @"User cancelled the Auth"}
+#define ERROR_FAILED_TO_LOAD @{@"error": @"a0.session.failed_load",@"error_description": @"Failed to load url"}


These errors are from moving existing error responses to constants. So there is no actual change of code, only location of code.

joshcanhelp · 2018-12-14T23:26:20Z

ios/A0Auth0.m

@@ -10,8 +13,12 @@
 #import <React/RCTUtils.h>
 #endif

+#define ERROR_CANCELLED @{@"error": @"a0.session.user_cancelled",@"error_description": @"User cancelled the Auth"}


"authentication"

Same as before

It's a message, though, so no reason not to correct it.

joshcanhelp · 2018-12-14T23:28:01Z

ios/A0Auth0.m

+                                      completionHandler:^(NSURL * _Nullable callbackURL,
+                                                          NSError * _Nullable error) {
+                                          if ([[error domain] isEqualToString:ASWebAuthenticationSessionErrorDomain]) {
+                                              switch ([error code]) {


switch is a bit overkill for a single option ...

joshcanhelp · 2018-12-14T23:28:52Z

ios/A0Auth0.m

@@ -87,22 +150,22 @@ - (NSString *)randomValue {

 - (NSString *)sign:(NSString*)value {
    CC_SHA256_CTX ctx;
-
+    


Unnecessary whitespace here and 👇

Oddly enough this is after running Xcode's Re-Indent it adds the whitespace, have removed.

Whitespace

taboulot · 2019-01-16T12:32:54Z

@cocojoe

We tested it and it works perfectly 👍

cocojoe · 2019-01-16T13:54:11Z

Thanks, will get this released soon.

expatyler · 2019-02-07T17:20:32Z

Any word on the release date for this @cocojoe ?

cocojoe · 2019-02-07T18:55:24Z

Sorry for delays, released 👍

This reverts commit 14efe5f.

…n-session Revert "Added iOS SF/ASWeb AuthenticationSession support (auth0#187)"

cocojoe mentioned this pull request Nov 7, 2018

Use SFAuthenticationSession on iOS11+ #158

Closed

luisrudge previously approved these changes Nov 8, 2018

View reviewed changes

cocojoe dismissed luisrudge’s stale review via bc64644 November 13, 2018 11:54

joshcanhelp reviewed Nov 13, 2018

View reviewed changes

cocojoe added 4 commits December 11, 2018 15:32

Added support for iOS *AuthenticationSession

6fdbb06

iOS 11 SFAuthenticationSession iOS 12 ASWebAuthenticationSession

Fix property setting

91fe7e2

Fix iOS Check, Small code tweak

512873b

Change callback format for Authorize response for iOS 11+

af6fea7

cocojoe force-pushed the added-authentication-session branch from 43045ce to af6fea7 Compare December 11, 2018 15:32

joshcanhelp suggested changes Dec 14, 2018

View reviewed changes

cocojoe added the CH: Changed label Dec 17, 2018

cocojoe added this to the v1-Next milestone Dec 17, 2018

Fix Callback Allocation Issue iOS<11

18d5e4f

Whitespace

joshcanhelp approved these changes Dec 17, 2018

View reviewed changes

Merge branch 'master' into added-authentication-session

2a3e372

cocojoe merged commit 14efe5f into master Jan 17, 2019

cocojoe deleted the added-authentication-session branch January 17, 2019 20:57

lbalmaceda modified the milestones: v1-Next, 1.4.0 Feb 7, 2019

nfcampos added a commit to GulaPetcare/react-native-auth0 that referenced this pull request Mar 12, 2019

Revert "Added iOS SF/ASWeb AuthenticationSession support (auth0#187)"

cea775f

This reverts commit 14efe5f.

nfcampos added a commit to GulaPetcare/react-native-auth0 that referenced this pull request Mar 12, 2019

Merge pull request #2 from GulaPetcare/revert-187-added-authenticatio…

000abc5

…n-session Revert "Added iOS SF/ASWeb AuthenticationSession support (auth0#187)"

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added iOS SF/ASWeb AuthenticationSession support #187

Added iOS SF/ASWeb AuthenticationSession support #187

cocojoe commented Nov 7, 2018 •

edited

Loading

cocojoe commented Nov 7, 2018

joshcanhelp Nov 13, 2018

cocojoe Nov 14, 2018

joshcanhelp Nov 13, 2018

cocojoe Nov 14, 2018

taboulot commented Dec 4, 2018

cocojoe commented Dec 4, 2018

MSSPL-PiyaleeMaiti commented Dec 11, 2018

cocojoe commented Dec 11, 2018

cocojoe commented Dec 12, 2018

taboulot commented Dec 13, 2018

MSSPL-PiyaleeMaiti commented Dec 13, 2018

joshcanhelp left a comment

joshcanhelp Dec 14, 2018

cocojoe Dec 17, 2018

joshcanhelp Dec 17, 2018

joshcanhelp Dec 14, 2018

cocojoe Dec 17, 2018

joshcanhelp Dec 17, 2018

joshcanhelp Dec 14, 2018

joshcanhelp Dec 14, 2018

cocojoe Dec 17, 2018

taboulot commented Jan 16, 2019

cocojoe commented Jan 16, 2019

expatyler commented Feb 7, 2019

cocojoe commented Feb 7, 2019

		@@ -87,22 +150,22 @@ - (NSString *)randomValue {

		- (NSString )sign:(NSString)value {
		CC_SHA256_CTX ctx;

Added iOS SF/ASWeb AuthenticationSession support #187

Added iOS SF/ASWeb AuthenticationSession support #187

Conversation

cocojoe commented Nov 7, 2018 • edited Loading

cocojoe commented Nov 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

taboulot commented Dec 4, 2018

cocojoe commented Dec 4, 2018

MSSPL-PiyaleeMaiti commented Dec 11, 2018

cocojoe commented Dec 11, 2018

cocojoe commented Dec 12, 2018

taboulot commented Dec 13, 2018

MSSPL-PiyaleeMaiti commented Dec 13, 2018

joshcanhelp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

taboulot commented Jan 16, 2019

cocojoe commented Jan 16, 2019

expatyler commented Feb 7, 2019

cocojoe commented Feb 7, 2019

cocojoe commented Nov 7, 2018 •

edited

Loading