Remove obsolete React dependency from podspec. #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, I read your issue and was going to suggest you raise a PR as you had the answers 😄 |
nfcampos
added a commit
to GulaPetcare/react-native-auth0
that referenced
this pull request
Mar 10, 2019
This reverts commit 359bc9b.
nfcampos
added a commit
to GulaPetcare/react-native-auth0
that referenced
this pull request
Mar 10, 2019
Revert "Remove obsolete React dependency from podspec. (auth0#192)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The React pod is deprecated and, since React Native already requires React, we should remove this dependency from A0Auth0.podspec.
References
This resolves issue #191 .
Testing
With Auth0 for React Native installed, simply attempt to
pod installfrom theios/directory in an ejected app that uses CocoaPods. This pod and all other pods should successfully install.Checklist