Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added token exchange for native social endpoint [SDK-1307] #273

Merged
merged 9 commits into from
Feb 6, 2020
Merged

Added token exchange for native social endpoint [SDK-1307] #273

merged 9 commits into from
Feb 6, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Feb 5, 2020 •
edited
Loading

Changes

References

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added CH: Added medium This PR may require moderate effort to action, or contains many changes to review labels Feb 5, 2020
@Widcket Widcket added this to the v2-Next milestone Feb 5, 2020
@Widcket Widcket requested a review from a team February 5, 2020 14:31
@Widcket Widcket changed the title Add token exchange for native social endpoint Added token exchange for native social endpoint Feb 5, 2020
@Widcket Widcket changed the title Added token exchange for native social endpoint Added token exchange for native social endpoint [SDK-1307] Feb 5, 2020
lbalmaceda
lbalmaceda suggested changes Feb 5, 2020
View reviewed changes
src/auth/index.js Show resolved Hide resolved
src/auth/index.js Outdated Show resolved Hide resolved
src/auth/index.js Outdated Show resolved Hide resolved
src/auth/index.js Outdated Show resolved Hide resolved
src/auth/index.js Outdated Show resolved Hide resolved
src/auth/index.js Outdated Show resolved Hide resolved
src/auth/index.js Outdated Show resolved Hide resolved
src/auth/index.js Outdated Show resolved Hide resolved
src/auth/__tests__/index.spec.js Show resolved Hide resolved
Widcket and others added 6 commits February 5, 2020 16:05
@Widcket @lbalmaceda
Update src/auth/index.js
6e46c80 
Co-Authored-By: Luciano Balmaceda <balmacedaluciano@gmail.com>
@Widcket @lbalmaceda
Update src/auth/index.js
aa77917 
Co-Authored-By: Luciano Balmaceda <balmacedaluciano@gmail.com>
@Widcket @lbalmaceda
Update src/auth/index.js
388b80d 
Co-Authored-By: Luciano Balmaceda <balmacedaluciano@gmail.com>
@Widcket @lbalmaceda
Update src/auth/index.js
b865672 
Co-Authored-By: Luciano Balmaceda <balmacedaluciano@gmail.com>
@Widcket @lbalmaceda
Update src/auth/index.js
bd6ea27 
Co-Authored-By: Luciano Balmaceda <balmacedaluciano@gmail.com>
@Widcket
Address requested changes
48d0d5a
@Widcket Widcket requested a review from lbalmaceda February 5, 2020 19:18
@lbalmaceda
Copy link
Contributor

There are still comments to be addressed ⚡️

lbalmaceda
lbalmaceda suggested changes Feb 6, 2020
View reviewed changes
src/auth/index.js Outdated Show resolved Hide resolved
@Widcket @lbalmaceda
Update src/auth/index.js
100614a 
Co-Authored-By: Luciano Balmaceda <balmacedaluciano@gmail.com>
@Widcket Widcket requested a review from lbalmaceda February 6, 2020 20:48
@Widcket Widcket merged commit 9f7fc24 into master Feb 6, 2020
@Widcket Widcket deleted the feature/code-exchange-native-social branch February 6, 2020 20:53
@Widcket Widcket mentioned this pull request Feb 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Added medium This PR may require moderate effort to action, or contains many changes to review
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.

token exchange API used by Sign In With Apple is missing
2 participants
@Widcket @lbalmaceda