Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skipLegacyListener [SDK-2760] #404

Merged
merged 3 commits into from
Sep 9, 2021
Merged

Add skipLegacyListener [SDK-2760] #404

merged 3 commits into from
Sep 9, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Sep 6, 2021 •
edited
Loading

Changes

This PR adds the skipLegacyListener option to authorize() and clearSession(), to allow skipping the event listener necessary for iOS <11 support.

Screen.Recording.2021-09-06.at.10.48.20.mov

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner September 6, 2021 15:02
@Widcket Widcket merged commit 1d9a7c4 into master Sep 9, 2021
@Widcket Widcket deleted the feature/skip-event-listener branch September 9, 2021 20:54
@Widcket Widcket mentioned this pull request Sep 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansims evansims evansims approved these changes

Assignees
No one assigned
Labels
CH: Added review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @evansims