Fix: Warning on RN 65. agent.js #411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Warning on RN 65
React Native version:
"react-native": "0.65.1",
Warn:
WARN EventEmitter.removeListener('url', ...): Method has been deprecated. Please instead use `remove()` on the subscription returned by `EventEmitter.addListener`.
Reference:
https://reactnative.dev/docs/linking#removeeventlistener
Changes:
//add variable to store the Event
let eventURL;
//set variable with the new event
eventURL = Linking.addEventListener('url', urlHandler);
//use event.remove() method instead of EventEmitter.removeListener('type',...)
eventURL.remove();
lbalmaceda
suggested changes
Sep 28, 2021
lbalmaceda
added
the
waiting for customer
This was referenced Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Warning on RN 65 #410
React Native version:
"react-native": "0.65.1",
Warn:
WARN EventEmitter.removeListener('url', ...): Method has been deprecated. Please instead use
remove()on the subscription returned byEventEmitter.addListener.Changes
add variable to store the Event
let eventURL;set variable with the new event
eventURL = Linking.addEventListener('url', urlHandler);use event.remove() method instead of EventEmitter.removeListener('type',...)
eventURL.remove();References
React Native Docs
Please note any links that are not publicly accessible.
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist
I have read the Auth0 general contribution guidelines
All existing and new tests complete without errors
All active GitHub checks have passed
[ ]