#409 Implement timeout support to networking Client #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnylen
force-pushed
the
feature/timeout
branch
from
c614bb0 to
bb47005
Compare
|
Hi @mnylen, thanks for raising this PR. I haven't been able to look at it yet, but might get to it by the end of the week. |
Widcket
reviewed
Dec 15, 2021
| return new Promise(resolve => { | ||
| responseTimerId = setTimeout(() => { | ||
| resolve(response); | ||
| }, 10000); |
There was a problem hiding this comment.
10 secs is a bit much for a test timeout, please lower it to 2 or 3 seconds.
Widcket
reviewed
Dec 15, 2021
|
@Widcket thanks for the feedback. I changed the test timeout. Sorry it took a while. Switched companies and not in a project that uses this anymore and don't have the setup locally on my computer anymore either, but hopefully others can find this change useful. :) |
|
Thanks for coming back and pushing the change! |
Widcket
approved these changes
Jan 7, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Auth0that is passed tonetworking.Client(defaults to 10 seconds)networking.Clienttimeout after the specified timeout, and any ongoing requests are cancelled usingAbortControllercreated for each request.TimeoutErrorReferences
Please include relevant links supporting this change such as a:
Testing
Can be tested in e.g. iOS Simulator using Network Link Condition preferences pane. Setting the packet drop ratio to 100 % will cause the requests to never complete. With this change,
TimeoutErrorwill be thrown after attempting the request for 10 seconds.Checklist