Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS module import for Expo SDK 44 #455

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Conversation

Bardiamist
Copy link
Contributor

From expo/expo#15622 (comment), the double-quoted react header imports will break building on Expo SDK 44. The double-quoted imports should be for react-native < 0.40. as nowadays react-native uses CocoaPods, it should be safe to use the angle-bracket import.

@Bardiamist Bardiamist requested a review from a team as a code owner February 3, 2022 08:06
@stevewillard
Copy link

If this fixes using this library in Expo, I'd be super interested to see this get merged!

@codebutler
Copy link

@evansims How can we help get this merged and released?

@poovamraj
Copy link
Contributor

poovamraj commented Feb 23, 2022

Hey all, We are seriously considering supporting Expo in our project. We will look into this PR soon but it requires some internal discussion that we have already started. I will keep you updated on this and try to provide an update soon. Thanks for your patience.

@stevewillard
Copy link

Oh my - if this could make it into a new react-native-auth0 release, that would be amazing! ❤️ 🙏

@Bardiamist
Copy link
Contributor Author

This fix for bare react native projects with Expo. Not for Expo projects.

@Widcket Widcket merged commit 9add5fa into auth0:master Mar 29, 2022
@Widcket Widcket mentioned this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants