Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3736] Fix: Options Parameter not being passed in Hooks authorize method #542

Merged
merged 3 commits into from
Oct 25, 2022
Merged

[SDK-3736] Fix: Options Parameter not being passed in Hooks authorize method #542

merged 3 commits into from
Oct 25, 2022

Conversation

poovamraj
Copy link
Contributor

Changes

  • We have passed the options parameter to underlying authorize call
  • We have added tests to avoid this regression in future

References

GH Issue - #539
PR - #540

Testing

  • Added Unit tests
  • Manually tested if ephemeral sessions are working

Thanks to @ebg for filing this issue and providing a fix through PR. We couldn't use that one due to additional changes which is something we will be considering adding as well.

@poovamraj poovamraj requested a review from a team as a code owner October 25, 2022 14:13
@poovamraj poovamraj enabled auto-merge (squash) October 25, 2022 15:04
@poovamraj poovamraj merged commit 5aa3e01 into master Oct 25, 2022
@poovamraj poovamraj deleted the fix-param-not-passed branch October 25, 2022 15:06
@poovamraj poovamraj mentioned this pull request Oct 27, 2022
Closed
2 tasks
@chrismcleod chrismcleod mentioned this pull request Oct 28, 2022
Merged
5 tasks
@poovamraj poovamraj mentioned this pull request Nov 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poovamraj @Widcket