Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a unix timestamp for expiresIn #551

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

cranberyxl
Copy link
Contributor

@cranberyxl cranberyxl commented Nov 11, 2022

Changes

You can only return JSON primitives over the bridge, the Foundation Date comes back as null for this reason.

Testing

Look at the credentials returned from CredentialsManager via the bridge.

const auth = new Auth0(...) 

auth.credentialsManager.getCredentials().then(console.log)
  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@cranberyxl cranberyxl requested a review from a team as a code owner November 11, 2022 17:18
Copy link
Contributor

@poovamraj poovamraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great catch! I have added a suggestion. Once it is merged, we can add this to the next release. Thanks a lot!

ios/CredentialsManagerBridge.swift Outdated Show resolved Hide resolved
Co-authored-by: Poovamraj T T <poovamraj@gmail.com>
@poovamraj poovamraj enabled auto-merge (squash) November 15, 2022 22:04
@poovamraj poovamraj merged commit 9616298 into auth0:master Nov 15, 2022
@poovamraj poovamraj mentioned this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants