compiler: adds a helper method to require any object type prefix #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroldanbet
force-pushed
the
add-helper-require-object-type-prefix
branch
from
f7d332c to
8fcbab3
Compare
jzelinskie
approved these changes
Jan 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to breaking changes from #1679 and subsequent fixes in #1683
The compiler API contract allowed clients to enforce the schema having any prefix not just one specific. The Safeguards introduced in #1683 mean it was no longer possible to achieve the same semantics originally exposed.
This introduces a new
OptionRequirePrefixedObjectTypewhich will cause the compiler to fail if a namespace or caveat is found without prefixes. The alternativeObjectTypePrefixshould be used when a specific object type prefix is required.