Add Self bounds from methods and ?Sized relaxation (if possible) to impl header
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's only impossible when there is `Self` by value in in parameter or return position in any method. This commit does not yet check for `Self` in non-receiver parameters as this crate cannot deal with that yet anyway. Furthermore, a `where Self: Sized` bound on methods does not help in that we still cannot add the `?Sized` relaxation. This is related to issue #11.
|
This looks good to me! It might be worth adding a compile test that has an explicit |
Currently, the `impl` block we generate for those traits is a bit stupid as it contains `T: Trait + ?Sized` (where `Trait: Sized`), but it compiles fine. So I don't see a reason to make our code more complicated just to avoid this strangeness.
|
@KodrAus Good point! I forgot about that. Luckily the current implementation seems to work fine with these traits. |
This was referenced Jul 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two fairly independent features, so I'm not quite sure why I'm trying to merge both in one PR 🤔 At least there are two commits!
Commit 1 solves #52 as it adds a
?Sizedrelaxation to the proxy type on the impl header whenever it's possible.Commit 2 solves #11 in that it searches for all
Selfbounds on methods and adds them to the proxy parameter. This is unfortunate, but the only sane way to handle that.@KodrAus If you don't have the time, just tell me, then we'll merge this unreviewed. I would probably publish this as
0.4.0after merging, if you are fine with that?