Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(parsing): improve handling of parentheses #55

Merged
merged 1 commit into from
May 1, 2023
Merged

enhancement(parsing): improve handling of parentheses #55

merged 1 commit into from
May 1, 2023

Conversation

s0up4200
Copy link
Contributor

@s0up4200 s0up4200 commented Apr 26, 2023 •
edited
Loading

if title ends with ) then replace it with ? instead of trimming it

@s0up4200
improve parsing of parentheses
e9c67e5 
if title ends with ) then replace it with ?
@s0up4200 s0up4200 added the enhancement New feature or request label Apr 26, 2023
@s0up4200
Copy link
Contributor Author

Tested with Sonarr. Success.

2023-04-26T19:02:01+02:00 DBG from a total of 4 shows we found 1 monitored and created 3 release titles client=sonarr type=sonarr
2023-04-26T19:02:01+02:00 DBG got 3 filter titles client=sonarr type=sonarr
2023-04-26T19:02:01+02:00 TRC The?Office*US?,The?Office*US,The?Office client=sonarr type=sonarr

Just a note: This wont affect the current way titles are parsed. It only adds one more version of titles that ends with eg. (US).

martylukyy
martylukyy approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@martylukyy martylukyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smacked an approve on it since soup tested it.

@zze0s zze0s merged commit 4751d1a into main May 1, 2023
@zze0s zze0s deleted the fix/improved-parsing-of-parentheses branch May 1, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martylukyy martylukyy martylukyy approved these changes

Assignees

@martylukyy martylukyy

@zze0s zze0s

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s0up4200 @martylukyy @zze0s