Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(formatting): adjust and simplify replace regex #74

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix(formatting): adjust and simplify replace regex #74

merged 1 commit into from
Feb 28, 2024

Conversation

nuxencs
Copy link
Contributor

@nuxencs nuxencs commented Feb 27, 2024 •
edited
Loading

This simplifies the replace regex by a lot and should also deal with a lot of additional cases.

s0up4200
s0up4200 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@s0up4200 s0up4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good to me!

Docker builds fail because its an external PR.

@nuxencs
Copy link
Contributor Author

nuxencs commented Feb 28, 2024

Docker builds fail because its an external PR.

yeah noticed that as well 😄

@s0up4200 s0up4200 merged commit 0ea22a3 into autobrr:main Feb 28, 2024
2 of 3 checks passed
@nuxencs nuxencs deleted the fix/replace-regex branch August 24, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zze0s zze0s zze0s approved these changes

@s0up4200 s0up4200 s0up4200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuxencs @s0up4200 @zze0s