Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename config.yml to config.yaml #81

Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix: rename config.yml to config.yaml #81

merged 1 commit into from
Apr 5, 2024

Conversation

s0up4200
Copy link
Contributor

@s0up4200 s0up4200 commented Apr 1, 2024

The program only starts with a .yaml file, so this might confuse those who copy the config.yml file from the root dir and get a Must supply omegabrr configuration! error on startup.

Steps to reproduce:

  1. Pull the repo
  2. Copy the config.yml into ./config
  3. Start the container
  4. Error: Must supply omegabrr configuration!
  5. ls config - omegabrr generates a new config.yaml since it does not find any existing.

The program only starts with a .yaml file, so this might confuse those who copy the config.yml file from the root dir.
@s0up4200 s0up4200 added the bug Something isn't working label Apr 1, 2024
@s0up4200 s0up4200 requested a review from zze0s April 1, 2024 20:23
Copy link
Contributor

@zze0s zze0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow 😅 Great find!

@zze0s zze0s merged commit cef5aa1 into main Apr 5, 2024
10 checks passed
@zze0s zze0s deleted the fix/config-example branch April 5, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants