Make WithMetadataFrom for open generics public

autofac · Dec 13, 2021 · be6efa3 · be6efa3
1 parent 4816f0a
commit be6efa3
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 37 deletions.
diff --git a/src/Autofac/Features/Scanning/OpenGenericScanningRegistrationExtensions.cs b/src/Autofac/Features/Scanning/OpenGenericScanningRegistrationExtensions.cs
@@ -250,42 +250,5 @@ public static IRegistrationBuilder<TLimit, OpenGenericScanningActivatorData, TRe
                 .Where(candidateType => candidateType.IsOpenGenericTypeOf(openGenericServiceType))
                 .As(candidateType => (Service)new KeyedService(serviceKeyMapping(candidateType), candidateType));
         }
-
-        /// <summary>
-        /// Use the properties of an attribute (or interface implemented by an attribute) on the scanned type
-        /// to provide metadata values.
-        /// </summary>
-        /// <remarks>Inherited attributes are supported; however, there must be at most one matching attribute
-        /// in the inheritance chain.</remarks>
-        /// <typeparam name="TAttribute">The attribute applied to the scanned type.</typeparam>
-        /// <param name="registration">Registration to set metadata on.</param>
-        /// <returns>Registration builder allowing the registration to be configured.</returns>
-        public static IRegistrationBuilder<object, OpenGenericScanningActivatorData, DynamicRegistrationStyle>
-            WithMetadataFrom<TAttribute>(
-                this IRegistrationBuilder<object, OpenGenericScanningActivatorData, DynamicRegistrationStyle> registration)
-        {
-            var attrType = typeof(TAttribute);
-            var metadataProperties = attrType
-                .GetRuntimeProperties()
-                .Where(pi => pi.CanRead);
-
-            return registration.WithMetadata(t =>
-            {
-                var attrs = t.GetCustomAttributes(true).OfType<TAttribute>().ToList();
-
-                if (attrs.Count == 0)
-                {
-                    throw new ArgumentException(string.Format(CultureInfo.CurrentCulture, RegistrationExtensionsResources.MetadataAttributeNotFound, typeof(TAttribute), t));
-                }
-
-                if (attrs.Count != 1)
-                {
-                    throw new ArgumentException(string.Format(CultureInfo.CurrentCulture, RegistrationExtensionsResources.MultipleMetadataAttributesSameType, typeof(TAttribute), t));
-                }
-
-                var attr = attrs[0];
-                return metadataProperties.Select(p => new KeyValuePair<string, object?>(p.Name, p.GetValue(attr, null)));
-            });
-        }
     }
 }
diff --git a/src/Autofac/RegistrationExtensions.OpenGenericAssemblyScanning.cs b/src/Autofac/RegistrationExtensions.OpenGenericAssemblyScanning.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
+using System.Globalization;
 using System.Linq;
 using System.Reflection;
 using Autofac.Builder;
@@ -320,5 +321,42 @@ public static IRegistrationBuilder<TLimit, OpenGenericScanningActivatorData, TRe
             registration.ActivatorData.ConfigurationActions.Add((t, rb) => rb.WithMetadata(metadataMapping(t)));
             return registration;
         }
+
+        /// <summary>
+        /// Use the properties of an attribute (or interface implemented by an attribute) on the scanned type
+        /// to provide metadata values.
+        /// </summary>
+        /// <remarks>Inherited attributes are supported; however, there must be at most one matching attribute
+        /// in the inheritance chain.</remarks>
+        /// <typeparam name="TAttribute">The attribute applied to the scanned type.</typeparam>
+        /// <param name="registration">Registration to set metadata on.</param>
+        /// <returns>Registration builder allowing the registration to be configured.</returns>
+        public static IRegistrationBuilder<object, OpenGenericScanningActivatorData, DynamicRegistrationStyle>
+            WithMetadataFrom<TAttribute>(
+                this IRegistrationBuilder<object, OpenGenericScanningActivatorData, DynamicRegistrationStyle> registration)
+        {
+            var attrType = typeof(TAttribute);
+            var metadataProperties = attrType
+                .GetRuntimeProperties()
+                .Where(pi => pi.CanRead);
+
+            return registration.WithMetadata(t =>
+            {
+                var attrs = t.GetCustomAttributes(true).OfType<TAttribute>().ToList();
+
+                if (attrs.Count == 0)
+                {
+                    throw new ArgumentException(string.Format(CultureInfo.CurrentCulture, RegistrationExtensionsResources.MetadataAttributeNotFound, typeof(TAttribute), t));
+                }
+
+                if (attrs.Count != 1)
+                {
+                    throw new ArgumentException(string.Format(CultureInfo.CurrentCulture, RegistrationExtensionsResources.MultipleMetadataAttributesSameType, typeof(TAttribute), t));
+                }
+
+                var attr = attrs[0];
+                return metadataProperties.Select(p => new KeyValuePair<string, object?>(p.Name, p.GetValue(attr, null)));
+            });
+        }
     }
 }