Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1030 - Allow ParameterFilterAttribute to check if parameter can be resolved #1053

Merged
merged 5 commits into from
Nov 26, 2019
Merged

Fix #1030 - Allow ParameterFilterAttribute to check if parameter can be resolved #1053

merged 5 commits into from
Nov 26, 2019

Conversation

RaymondHuy
Copy link
Member

Add new method to ParameterFilterAttribute to check if parameter can be resolved.

@tillig tillig changed the title Fix Issue#1030 Fix #1030 - Allow ParameterFilterAttribute to check if parameter can be resolved Nov 26, 2019
tillig
tillig requested changes Nov 26, 2019
View reviewed changes
Copy link
Member

@tillig tillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better. I think having the "can resolve" concept in the attributes like it is elsewhere makes sense. I think the logic in the MetadataFilterAttribute may be able to be simplified a bit by removing some redundant bits, but otherwise looks good.

src/Autofac/Features/AttributeFilters/MetadataFilterAttribute.cs Outdated Show resolved Hide resolved
tillig
tillig approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@tillig tillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thanks!

@tillig tillig merged commit 53a10c1 into autofac:develop Nov 26, 2019
@RaymondHuy RaymondHuy deleted the Issue1030 branch February 6, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillig tillig tillig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaymondHuy @tillig