Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 6 Support #1306

Merged
merged 13 commits into from
Feb 23, 2022
Merged

.NET 6 Support #1306

merged 13 commits into from
Feb 23, 2022

Conversation

tillig
Copy link
Member

@tillig tillig commented Feb 23, 2022

Includes:

  • Adding net6.0 TFM to all projects.
  • Updating test framework, analyzer, and other dev dependencies.
  • Resolving new analyzer warnings, primarily:
    • Use the new operator to simplify object creation.
    • Pattern matching - x is not y instead of !(x is y), x is not null instead of x is object.
    • Marking things static that don't access instance data (really only in test fixtures).

A future PR can do some cleanup like setting up ImplicitUsings and file-scoped namespaces.

@tillig
Copy link
Member Author

tillig commented Feb 23, 2022

This PR supersedes #1300.

Copy link
Member

@alistairjevans alistairjevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 1 real thing that should change, that's the !(not null) check which can be simplified. The rest are mostly just thoughts, options, etc.

I'll try not to take the British English spelling removal too personally... 😂

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #1306 (75f9eb9) into develop (be2a437) will increase coverage by 0.25%.
The diff coverage is 90.62%.

❗ Current head 75f9eb9 differs from pull request most recent head 7511216. Consider uploading reports for the commit 7511216 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1306      +/-   ##
===========================================
+ Coverage    76.57%   76.83%   +0.25%     
===========================================
  Files          188      188              
  Lines         5183     5180       -3     
  Branches      1062     1061       -1     
===========================================
+ Hits          3969     3980      +11     
+ Misses         714      702      -12     
+ Partials       500      498       -2     
Impacted Files Coverage Δ
...Resolving/Pipeline/DefaultResolveRequestContext.cs 83.87% <0.00%> (ø)
src/Autofac/Core/Resolving/SegmentedStack.cs 78.12% <ø> (ø)
...tofac/Diagnostics/OperationDiagnosticTracerBase.cs 69.23% <ø> (ø)
...tweightAdapters/LightweightAdapterActivatorData.cs 100.00% <ø> (ø)
src/Autofac/Util/AssemblyExtensions.cs 40.00% <0.00%> (ø)
src/Autofac/Util/FallbackDictionary.cs 76.08% <ø> (ø)
src/Autofac/Util/LinkerAttributes.cs 0.00% <ø> (ø)
src/Autofac/Util/ReflectionExtensions.cs 50.00% <33.33%> (ø)
...tofac/Core/Registration/ServiceRegistrationInfo.cs 78.37% <60.00%> (ø)
src/Autofac/Builder/BuildCallbackManager.cs 100.00% <100.00%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be2a437...7511216. Read the comment docs.

@tillig
Copy link
Member Author

tillig commented Feb 23, 2022

The British English changes were either...

  • 💯 personal attack - you want some, come get some! 😈 🤣
  • standardization on US English because that's also what the API is in and it felt sort of weird to flip back and forth, especially in comments right above the API where the spellings conflicted.

I mean, you pick. Either way is cool 😉

Copy link
Member

@alistairjevans alistairjevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have decided your spelling changes are not an attack on my Britishness, so we're tickety boo guv-ner!

@tillig tillig merged commit bb051cf into develop Feb 23, 2022
@tillig tillig deleted the feature/net6 branch February 23, 2022 19:54
@maulik-modi
Copy link

@alistairjevans or @tillig , When do you plan to publish Nuget package?

@tillig
Copy link
Member Author

tillig commented Mar 7, 2022

@maulik-modi Is there something here that your code requires? The existing package should work perfectly well with .NET 6.

@maulik-modi
Copy link

maulik-modi commented Mar 18, 2022 via email

@tillig
Copy link
Member Author

tillig commented Mar 18, 2022

There's are no breaking changes. Instead of guessing, try it out and let us know if there's something you find not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants