Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump actionpack from 5.2.3 to 6.0.3.2 #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot-preview[bot]
Copy link

Bumps actionpack from 5.2.3 to 6.0.3.2. This update includes security fixes.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

Ability to forge per-form CSRF tokens given a global CSRF token It is possible to possible to, given a global CSRF token such as the one present in the authenticity_token meta tag, forge a per-form CSRF token for any action for that session.

Versions Affected: rails < 5.2.5, rails < 6.0.4 Not affected: Applications without existing HTML injection vulnerabilities. Fixed Versions: rails >= 5.2.4.3, rails >= 6.0.3.1

Impact

Given the ability to extract the global CSRF token, an attacker would be able to construct a per-form CSRF token for that session.

Workarounds

This is a low-severity security issue. As such, no workaround is necessarily until such time as the application can be upgraded.

Patched versions: ~> 5.2.4.3; >= 6.0.3.1 Unaffected versions: none

Sourced from The Ruby Advisory Database.

Possible Strong Parameters Bypass in ActionPack There is a strong parameters bypass vector in ActionPack.

Versions Affected: rails <= 6.0.3 Not affected: rails < 4.0.0 Fixed Versions: rails >= 5.2.4.3, rails >= 6.0.3.1

Impact

In some cases user supplied information can be inadvertently leaked from Strong Parameters. Specifically the return value of each, or each_value, or each_pair will return the underlying "untrusted" hash of data that was read from the parameters. Applications that use this return value may be inadvertently use untrusted user input.

Impacted code will look something like this:

def update
  # Attacker has included the parameter: `{ is_admin: true }`
  User.update(clean_up_params)
</tr></table> ... (truncated)

Patched versions: ~> 5.2.4.3; >= 6.0.3.1 Unaffected versions: < 4.0.0

Release notes

Sourced from actionpack's releases.

6.0.3.1

Active Support

  • [CVE-2020-8165] Deprecate Marshal.load on raw cache read in RedisCacheStore

  • [CVE-2020-8165] Avoid Marshal.load on raw cache value in MemCacheStore

Active Model

  • No changes.

Active Record

  • No changes.

Action View

  • [CVE-2020-8167] Check that request is same-origin prior to including CSRF token in XHRs

Action Pack

  • [CVE-2020-8166] HMAC raw CSRF token before masking it, so it cannot be used to reconstruct a per-form token

  • [CVE-2020-8164] Return self when calling #each, #each_pair, and #each_value instead of the raw @parameters hash

Active Job

  • No changes.

Action Mailer

  • No changes.

Action Cable

  • No changes.

Active Storage

... (truncated)
Changelog

Sourced from actionpack's changelog.

Rails 6.0.3.2 (June 17, 2020)

  • [CVE-2020-8185] Only allow ActionableErrors if show_detailed_exceptions is enabled

Rails 6.0.3.1 (May 18, 2020)

  • [CVE-2020-8166] HMAC raw CSRF token before masking it, so it cannot be used to reconstruct a per-form token

  • [CVE-2020-8164] Return self when calling #each, #each_pair, and #each_value instead of the raw @parameters hash

Rails 6.0.3 (May 06, 2020)

  • Include child session assertion count in ActionDispatch::IntegrationTest

    IntegrationTest#open_session uses dup to create the new session, which meant it had its own copy of @assertions. This prevented the assertions from being correctly counted and reported.

    Child sessions now have their attr_accessor overriden to delegate to the root session.

    Fixes #32142

    Sam Bostock

Rails 6.0.2.2 (March 19, 2020)

  • No changes.

Rails 6.0.2.1 (December 18, 2019)

  • Fix possible information leak / session hijacking vulnerability.

    The ActionDispatch::Session::MemcacheStore is still vulnerable given it requires the gem dalli to be updated as well.

    CVE-2019-16782.

Rails 6.0.2 (December 13, 2019)

  • Allow using mountable engine route helpers in System Tests.

    Chalo Fernandez

Rails 6.0.1 (November 5, 2019)

... (truncated)
Commits
  • fbe2433 Preparing for 6.0.3.2 release
  • 11052e0 Update changelog
  • 2121b9d Only allow ActionableErrors if show_detailed_exceptions is enabled
  • 34991a6 Preparing for 6.0.3.1 release
  • 2c8fe2a bumping version, updating changelog
  • 0ad524a update changelog
  • 29aa538 HMAC raw CSRF token before masking it, so it cannot be used to reconstruct a ...
  • b3230c5 Return self when calling #each, #each_pair, and #each_value instead of the ra...
  • b738f19 Preparing for 6.0.3 release
  • 509b9da Preparing for 6.0.3.rc1 release
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [actionpack](https://github.com/rails/rails) from 5.2.3 to 6.0.3.2. **This update includes security fixes.**
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v6.0.3.2/actionpack/CHANGELOG.md)
- [Commits](rails/rails@v5.2.3...v6.0.3.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file security Security related issues labels Jun 18, 2020
@dependabot-preview
Copy link
Author

Dependabot tried to add @ervalhous as a reviewer to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/autoforce/APIcasso/pulls/137/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the autoforce/APIcasso repository. // See: https://developer.github.com/v3/pulls/review_requests/#create-a-review-request

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2020

Codecov Report

Merging #137 into master will decrease coverage by 85.59%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #137       +/-   ##
===========================================
- Coverage   96.99%   11.40%   -85.60%     
===========================================
  Files          24       15        -9     
  Lines         931      614      -317     
===========================================
- Hits          903       70      -833     
- Misses         28      544      +516     
Impacted Files Coverage Δ
spec/requests/singularized/requests_spec.rb 1.87% <0.00%> (-97.50%) ⬇️
...equests/plurarized/requests_with_plurarize_spec.rb 1.87% <0.00%> (-97.50%) ⬇️
spec/token/token_spec.rb 4.23% <0.00%> (-95.77%) ⬇️
spec/requests/batch_spec.rb 6.12% <0.00%> (-93.88%) ⬇️
spec/requests/singularized/bad_requests_spec.rb 12.50% <0.00%> (-87.50%) ⬇️
...sts/plurarized/bad_requests_with_plurarize_spec.rb 12.50% <0.00%> (-87.50%) ⬇️
spec/models/used_model_spec.rb 41.17% <0.00%> (-58.83%) ⬇️
app/models/apicasso/key.rb 63.63% <0.00%> (-36.37%) ⬇️
spec/apicasso_spec.rb 66.66% <0.00%> (-33.34%) ⬇️
spec/dummy/app/models/used_model.rb 46.15% <0.00%> (-15.39%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a95b5fc...92dc05c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file security Security related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant