Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NamedTuple -> dataclass everywhere #1349

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Conversation

mseeger
Copy link
Contributor

@mseeger mseeger commented Oct 19, 2021

Issue #, if available:

Description of changes:
Removing NamedTuple everywhere makes step to Python 3.9 simpler.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mseeger mseeger requested a review from Innixma October 19, 2021 08:46
@szha
Copy link

szha commented Oct 19, 2021

Job PR-1349-2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1349/2/index.html

Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for helping clean-up the NamedTuple usage!

@Innixma Innixma merged commit bdc8b11 into master Oct 19, 2021
DolanTheMFWizard pushed a commit to DolanTheMFWizard/autogluon that referenced this pull request Oct 19, 2021
* Replace NqmedTuple -> dataclass everywhere

* Fixed imports
DolanTheMFWizard pushed a commit to DolanTheMFWizard/autogluon that referenced this pull request Oct 19, 2021
* Replace NqmedTuple -> dataclass everywhere

* Fixed imports
@Innixma Innixma deleted the remove_namedtuple branch November 22, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants