Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

object detection, add save() and load() #405

Merged
merged 3 commits into from
Apr 6, 2020
Merged

object detection, add save() and load() #405

merged 3 commits into from
Apr 6, 2020

Conversation

chongruo
Copy link
Contributor

@chongruo chongruo commented Apr 5, 2020

Add save() and load() for object detection

@szha
Copy link

szha commented Apr 5, 2020

Job PR-405-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-405/1/index.html

zhreshold
zhreshold reviewed Apr 5, 2020
View reviewed changes
autogluon/task/object_detection/nets.py
@@ -10,7 +10,7 @@ def _get_network(meta_arch, name, transfer_classes, ctx=mx.cpu()):
net = gcv.model_zoo.get_model(net_name,
classes=transfer_classes,
pretrained_base=False,
transfer='coco')
transfer=None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change to None this time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter here since we will load our trained model later and all weights will be updated. I just change it to None to make it consistent with faster-rcnn part
https://github.com/chongruo/autogluon/blob/d9cb58c2762fbcd496d3fec7ade57416fe2707bf/autogluon/task/object_detection/nets.py#L29

@zhreshold
Copy link
Contributor

Should fix #183, #282, #377

@zhanghang1989 @Innixma

zhanghang1989
zhanghang1989 approved these changes Apr 5, 2020
View reviewed changes
Copy link
Contributor

@zhanghang1989 zhanghang1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing it. Could you also add this method to the tutorial (also for image classification tutorial)?

@chongruo
Copy link
Contributor Author

chongruo commented Apr 5, 2020 •
edited
Loading

Thanks for implementing it. Could you also add this method to the tutorial (also for image classification tutorial)?

have added them to the tutorial

@szha
Copy link

szha commented Apr 6, 2020

Job PR-405-2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-405/2/index.html

@szha
Copy link

szha commented Apr 6, 2020

Job PR-405-3 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-405/3/index.html

@zhreshold zhreshold merged commit f43392d into autogluon:master Apr 6, 2020
@chongruo chongruo deleted the saveload branch April 6, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhanghang1989 zhanghang1989 zhanghang1989 approved these changes

@zhreshold zhreshold zhreshold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chongruo @szha @zhreshold @zhanghang1989