[hotfix] Parameterize category names for allowlist #1588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, nothing would happen when a user clicked on the switch icon between the "Included" and "Excluded" list for assignment categories that have spaces in the names (e.g. "Optional Assignments"). This was caused because the category names were being used as ID's, which caused the jQuery to return undefined for categories with spaces. This was fixed by altering the jQuery to look for
[id='included_${category}']
, rather than individual id tags (which looks for id's separated by spaces separately, causing nothing to be returned).How Has This Been Tested?
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting