Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Made grades section scrollable, deleted unnecessary headings in speedgrader #1596

Merged
merged 5 commits into from
Sep 28, 2022

Conversation

michellexliu
Copy link
Contributor

Description

Fixed issue where scroll bar was not showing up in the grades section, causing overflow to be hidden when the list of grading categories is long. Also touched up minor styling in the speedgrader, such as removing extraneous headers and aligning the symbol tree icons with the function names.
image

How Has This Been Tested?

  • Grades are scrollable on default view
  • Grades are scrollable when layout changes
  • Grades are non-scrollable when the list of grades is shorter than the grades window
  • All other components work properly
  • Grades window updates properly when annotation is added

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

@damianhxy
Copy link
Member

damianhxy commented Sep 26, 2022

Scrolling doesn't seem to work after I resize the window smaller, and then bigger

The problem is that the value of height on .problemGrades's parent becomes larger than it actually is, making the scrollbar not appear.

@damianhxy
Copy link
Member

fwiw, removing the arguments to myLayout.updateSize(); in the $(window).resize handler seems to fix this issue.

According to the golden-layout documentation, If no arguments are provided GoldenLayout measures its container and resizes accordingly.

@michellexliu michellexliu requested review from damianhxy and removed request for damianhxy September 28, 2022 15:36
@damianhxy
Copy link
Member

Currently, when I add many annotations, scrolling inside the annotations box is a bit janky -- it takes two scrolls to get to the bottom. And when I make the annotations panel full height (e.g. by moving grades next to it), the text is cut off halfway.

Recording.mov

The issue seems to be the max-height: 350px; style for .annotationSummary ul. Unless there's a good reason to keep it, removing it seems to fix the issue.

Copy link
Member

@damianhxy damianhxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@michellexliu michellexliu merged commit 9ee5108 into master Sep 28, 2022
@michellexliu michellexliu deleted the grades-scrollable branch September 28, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants