Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show revised due date for manage extensions #1623

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

michellexliu
Copy link
Contributor

Description

Created a column in the "manage extensions" table that shows the revised due date after accounting for the extensions.
Screen Shot 2022-10-13 at 12 37 56 PM

Motivation and Context

Requested by Zack Weinberg.

How Has This Been Tested?

  • Extensions with varying number of days
  • Infinite extensions
  • New column shows on update & delete
  • Tested on several laptop screen sizes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Copy link
Contributor

@20wildmanj 20wildmanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michellexliu michellexliu merged commit bc06be6 into master Oct 19, 2022
@michellexliu michellexliu deleted the revised-late-day branch October 19, 2022 14:27
damianhxy added a commit that referenced this pull request Oct 27, 2022
* Add line number

* Move active class

* Add lineNumber when updating

* Change score field to type number

* Consistently display annotation scores to 1 d.p.

* Fix plus_fix

* Sort annotations after updates

* Add sorting logic

* Match get_correct_filename behavior

* Round grades to 1dp

* Fix indentation

* Disable accordion (to allow multiple sections open at once)

* annotation.js cleanup

* Remove max-height on collapsible

* Run attachChangeFileEvents once at the end

* Group annotations by filename

* Implement group_by for js

* Add collapsible arrows

* Add collapsible arrows (after update)

* Increase arrow size

* Disable user-select on header

* Add spacing between annotations of different files

* Remove debug statement

* Use jquery load for annotations

* Remove dead code

* Revert filelist from instance to local variable

* Fixed annotation switching problems not updating score (#1621)

* Force flatpicker interface for date/datetime picker on mobile (#1620)

* Validate against empty annotation scores

* Fix annotation score validation on backend

* Simplify badge color update logic

* Prevent blank annotation scores on update

* Simplify badge color update logic (fix)

* Show revised due date for manage extensions (#1623)

show revised due date

* Bump nokogiri from 1.13.6 to 1.13.9 (#1625)

* make submission summary fill up space (#1624)

* - fix submission summary/history table to fill up horizontal space, but still overflow properly
  - only show link to full submission history table if submissions exceed summary view limit
* - make "Download Submission" and "View Source" into buttons
* Vertically center-align icon and text
* add spaces, move view source to be above download submission

* round 2 decimal places

* plusFix round to 2 decimal places

* Change grades panel to use 2dp

Co-authored-by: Nicholas AJ Clark <nicholas@californiaclarks.com>
Co-authored-by: Michelle Liu <mliuu3259@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joey Wildman <josephwildman88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants