Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Metrics to CSV #1655

Merged
merged 7 commits into from
Nov 29, 2022
Merged

Export Metrics to CSV #1655

merged 7 commits into from
Nov 29, 2022

Conversation

victorhuangwq
Copy link
Contributor

Description

image

Format of the CSV as attached
student_metrics_11_27_2022, 2_54_33 PM.csv

Allows metrics to be exported to CSV. As of current it is only added to the pending tab.

Motivation and Context

Based on user interviews with 213 TAs.

How Has This Been Tested?

Test cases:

  • Clicking Export when there are nothing selected, nothing happens
  • Clicking select all and export. Should generate a csv to be downloaded with all the students on the page
  • Click a few and export. Should generate a csv with only those students.

Switching to the other tabs, the export button shouldn't appear

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

@victorhuangwq
Copy link
Contributor Author

@gfieni2022 Would this Export to CSV feature help address your issue?

Copy link
Contributor

@20wildmanj 20wildmanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export function works locally, data looks right, LGTM

@gfieni2022
Copy link

Hello! Yes, this change looks great. Thank you for listening to my feedback!

@victorhuangwq victorhuangwq merged commit 2d4258b into master Nov 29, 2022
@victorhuangwq victorhuangwq deleted the export-metrics-csv branch November 29, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants